Vibration is a killer for batteries, but a charging system that's not "sorted" is just as damaging.

Don't waste more money on batteries till the dynamo/regulator is working properly.

Most ordinary batteries can give fair service as long as they're not flapping about and kept fully charged (not boiled).